Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception thrown in `catch-error-name` rule #363

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@hikerpig
Copy link
Contributor

commented Sep 9, 2019

While retrieving variables to fix, in order to get all variables inside the scope, one
may iterate childScopes recursively.

Or use getDeclaredVariables, it always return an array, won't thrown exceptions if there are no matches.

Closes #350.


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

@MrHen
MrHen approved these changes Sep 9, 2019

@sindresorhus sindresorhus changed the title Fix exception thrown in "catch-error-name" rule Fix exception thrown in `catch-error-name` rule Sep 16, 2019

@sindresorhus sindresorhus merged commit 05641ba into sindresorhus:master Sep 16, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 97.951%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.