From 113a7fe3fb7d1e68d419b94f1d3891e79439877e Mon Sep 17 00:00:00 2001
From: ehmicky <ehmicky@users.noreply.github.com>
Date: Sun, 5 May 2024 18:58:41 +0100
Subject: [PATCH] Run tests on Node.js 22 (#1024)

---
 .github/workflows/main.yml    |  2 +-
 test/terminate/kill-signal.js | 23 ++++++++++++++++++++---
 2 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index e4250576cd..6dbb800f45 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -10,7 +10,7 @@ jobs:
       fail-fast: false
       matrix:
         node-version:
-          - 20
+          - 22
           - 18
         os:
           - ubuntu
diff --git a/test/terminate/kill-signal.js b/test/terminate/kill-signal.js
index c7c710fe7b..ef84b9d2c5 100644
--- a/test/terminate/kill-signal.js
+++ b/test/terminate/kill-signal.js
@@ -1,4 +1,5 @@
 import {once} from 'node:events';
+import {platform, version} from 'node:process';
 import {setImmediate} from 'node:timers/promises';
 import test from 'ava';
 import {execa} from '../../index.js';
@@ -6,14 +7,30 @@ import {setFixtureDirectory} from '../helpers/fixtures-directory.js';
 
 setFixtureDirectory();
 
+const isWindows = platform === 'win32';
+const majorNodeVersion = Number(version.split('.')[0].slice(1));
+
 test('Can call `.kill()` multiple times', async t => {
 	const subprocess = execa('forever.js');
 	subprocess.kill();
 	subprocess.kill();
 
-	const {isTerminated, signal} = await t.throwsAsync(subprocess);
-	t.true(isTerminated);
-	t.is(signal, 'SIGTERM');
+	const {exitCode, isTerminated, signal, code} = await t.throwsAsync(subprocess);
+
+	// On Windows, calling `subprocess.kill()` twice emits an `error` event on the subprocess.
+	// This does not happen when passing an `error` argument, nor when passing a non-terminating signal.
+	// There is no easy way to make this cross-platform, so we document the difference here.
+	if (isWindows && majorNodeVersion >= 22) {
+		t.is(exitCode, undefined);
+		t.false(isTerminated);
+		t.is(signal, undefined);
+		t.is(code, 'EPERM');
+	} else {
+		t.is(exitCode, undefined);
+		t.true(isTerminated);
+		t.is(signal, 'SIGTERM');
+		t.is(code, undefined);
+	}
 });
 
 test('execa() returns a promise with kill()', async t => {