Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the windowsHide option #388

Merged
merged 2 commits into from Nov 12, 2019
Merged

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented Nov 9, 2019

Fixes #371.

At the moment, we force the windowsHide option to be true. However this prevents CTRL-C from working on Windows.

This PR allows windowsHide to be set to false. It keeps the default value as true.

@sindresorhus sindresorhus merged commit 717d29d into master Nov 12, 2019
@sindresorhus sindresorhus deleted the feat/windows-hide branch November 12, 2019 05:14
@papb
Copy link
Contributor

papb commented Nov 12, 2019

Ahhh!! So there is a reason Ctrl+C always seemed buggy for me 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider allowing windowsHide option
3 participants