add test case for throwing on non-executables #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you be able to fix the merge conflict? |
|
Sure :) |
|
I think it may be hard to test on windows boxes :( |
|
I will give it some thoughts tomorrow. |
windows platform do not know about executable flags in a unix/linux sense. Therefore this test will fail on windows and we skip it.
| @@ -166,6 +167,13 @@ test(`use relative path with '..' chars`, async t => { | |||
| t.is(stdout, 'foo'); | |||
| }); | |||
|
|
|||
| test('execa() throws if running non executable', async t => { | |||
| // windows systems do not know executable-flags | |||
| if (os.platform() !== 'win32') { | |||
There was a problem hiding this comment.
Better to wrap the whole test in that if statement. Also no need to import os. Just use process.platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a test case for #47
In master this does not fail anymore, but a test case if it may help to avoid regression