Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verbose flag #40

Closed
wants to merge 2 commits into from
Closed

Conversation

sharathgeorgem
Copy link

@sharathgeorgem sharathgeorgem commented Dec 17, 2019

The --verbose flag can be used to get further details like latency stats and server location.

@itaisteinherz itaisteinherz mentioned this pull request Dec 17, 2019
@sindresorhus
Copy link
Owner

The output is pretty good. It could use some more perfection and whitespace though:



   ⠏ 43 Mbps ↓ / - Mbps ↑


   Latency:  2ms (unloaded)  1ms (loaded)
    Client:  Makkasan, TH 2405:9800:bc02:1fcd:cc24:acbb:de29:69da AIS
   Servers:  Chonburi, TH  |  Pathum Thani, TH  |  Huaikhwang, TH
  • Notice the whitespace, indentation, etc.
  • "Client" and "Servers" should always be gray and not green.
  • (unloaded) and (loaded should be chalk.dim().

@sindresorhus
Copy link
Owner

You also need to add the flag to the meow config and the readme. See: https://github.com/sindresorhus/fast-cli/pull/41/files

return {
downloadSpeed: Number($('#speed-value').textContent),
uploadSpeed: Number($('#upload-value').textContent),
downloadUnit: $('#speed-units').textContent.trim(),
uploadUnit: $('#upload-units').textContent.trim(),
latencyValue: Number($('#latency-value').textContent),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop the Value postfix on these variables.

@sindresorhus sindresorhus changed the title Add verbose flag functionality Add verbose flag Feb 16, 2020
@sindresorhus
Copy link
Owner

Closing in favor of #41.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants