From 1ee643a31621eb1ac845a9558c4b9f4a88d0dca0 Mon Sep 17 00:00:00 2001 From: Sindre Sorhus Date: Tue, 24 Jul 2018 09:23:11 +0700 Subject: [PATCH] Remove number argument Use `getPort({port: })` instead. --- index.js | 10 ++-------- test.js | 4 ++-- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/index.js b/index.js index c3dd477..00bcb70 100644 --- a/index.js +++ b/index.js @@ -14,12 +14,6 @@ const isAvailable = options => new Promise((resolve, reject) => { }); const getPort = (options = {}) => new Promise((resolve, reject) => { - // For backwards compatibility with number-only input - // TODO: Remove this in the next major version - if (typeof options === 'number') { - options = {port: options}; - } - if (typeof options.port === 'number') { options.port = [options.port]; } @@ -34,5 +28,5 @@ const getPort = (options = {}) => new Promise((resolve, reject) => { }); module.exports = options => options ? - getPort(options).catch(() => getPort(0)) : - getPort(0); + getPort(options).catch(() => getPort({port: 0})) : + getPort({port: 0}); diff --git a/test.js b/test.js index c30115b..a361616 100644 --- a/test.js +++ b/test.js @@ -16,7 +16,7 @@ test('port can be bound when promise resolves', async t => { test('preferred port', async t => { const desiredPort = 8080; - const port = await m(desiredPort); + const port = await m({port: desiredPort}); t.is(port, desiredPort); }); @@ -28,7 +28,7 @@ test('preferred port unavailable', async t => { const server = net.createServer(); await pify(server.listen.bind(server))(desiredPort); - const port = await m(desiredPort); + const port = await m({port: desiredPort}); t.is(typeof port, 'number'); t.true(port > 0); t.not(port, desiredPort);