Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native stream.pipeline instead of pump package #39

Merged
merged 8 commits into from Aug 10, 2020

Conversation

@tiagonapoli
Copy link
Contributor

@tiagonapoli tiagonapoli commented Jun 26, 2020

This PR replaces the use of the pump package with the native stream.pipeline, introduced on node@10.0.0 (requested on #33). This fixes #38.

Also, a nit, it replaces return Promise.reject(new Error...) with throw new Error...

This is a breaking change

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

@sindresorhus sindresorhus commented Jul 3, 2020

Travis is failing.

@tiagonapoli
Copy link
Contributor Author

@tiagonapoli tiagonapoli commented Jul 3, 2020

Thanks for the review! I will correct the code :)
Travis is failing on node@8.x tests - this PR is a breaking change that will drop support for node8, because stream.pipeline was introduced on node 10

@tiagonapoli tiagonapoli requested a review from sindresorhus Jul 3, 2020
index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

@sindresorhus sindresorhus commented Jul 15, 2020

this PR is a breaking change that will drop support for node8, because stream.pipeline was introduced on node 10

I'll drop support for Node.js 8 after this PR is merged.

@sindresorhus sindresorhus changed the title Use native stream.pipeline instead of pump package Use native stream.pipeline instead of pump package Aug 9, 2020
@sindresorhus
Copy link
Owner

@sindresorhus sindresorhus commented Aug 9, 2020

Can you fix the merge conflict? Also see #39 (comment)

tiagonapoli and others added 7 commits Aug 9, 2020
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
@sindresorhus sindresorhus merged commit 5cf31ba into sindresorhus:master Aug 10, 2020
1 check failed
@rogerkjoy
Copy link

@rogerkjoy rogerkjoy commented Dec 15, 2020

FYI -
This appears that it may have broken React 17 users in browser, via neat-csv which was working up until this change.

Not meaningful for us, we were able to just remove uses of neat-csv, and thus remove the dependency. I'm not really asking for a change, just thought you may want to be aware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants