Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.0.0 πŸ’₯ #140

Merged
merged 25 commits into from Jan 7, 2016
Merged

6.0.0 πŸ’₯ #140

merged 25 commits into from Jan 7, 2016

Conversation

floatdrop
Copy link
Contributor

Overview

6.0.0 release drops Node.JS 0.10/0.12 support, so now we can replace lots of modules and reduce dependency tree more than twice:

got@5.2.0                               got@6.0.0
β”œβ”€β”¬ create-error-class@2.0.1            β”œβ”€β”¬ create-error-class@3.0.0
β”‚ β”œβ”€β”€ capture-stack-trace@1.0.0         β”‚ └── capture-stack-trace@1.0.0
β”‚ └── inherits@2.0.1                    β”œβ”€β”€ @floatdrop/duplexer2@0.1.4
β”œβ”€β”¬ duplexify@3.4.2                     β”œβ”€β”€ get-stream@1.1.0
β”‚ β”œβ”€β”¬ end-of-stream@1.0.0               β”œβ”€β”€ is-plain-obj@1.1.0
β”‚ β”‚ └─┬ once@1.3.3                      β”œβ”€β”€ is-redirect@1.0.0
β”‚ β”‚   └── wrappy@1.0.1                  β”œβ”€β”€ is-stream@1.0.1
β”‚ └─┬ readable-stream@2.0.4             β”œβ”€β”€ lowercase-keys@1.0.0
β”‚   β”œβ”€β”€ core-util-is@1.0.2              β”œβ”€β”€ node-status-codes@1.0.0
β”‚   β”œβ”€β”€ inherits@2.0.1                  β”œβ”€β”€ timed-out@2.0.0
β”‚   β”œβ”€β”€ isarray@0.0.1                   β”œβ”€β”€ unzip-response@1.0.0
β”‚   β”œβ”€β”€ process-nextick-args@1.0.5      └─┬ url-parse-lax@1.0.0
β”‚   β”œβ”€β”€ string_decoder@0.10.31            └── prepend-http@1.0.3
β”‚   └── util-deprecate@1.0.2
β”œβ”€β”€ is-plain-obj@1.1.0
β”œβ”€β”€ is-redirect@1.0.0
β”œβ”€β”€ is-stream@1.0.1
β”œβ”€β”€ lowercase-keys@1.0.0
β”œβ”€β”€ node-status-codes@1.0.0
β”œβ”€β”€ object-assign@4.0.1
β”œβ”€β”¬ parse-json@2.2.0
β”‚ └─┬ error-ex@1.3.0
β”‚   └── is-arrayish@0.2.1
β”œβ”€β”¬ pinkie-promise@2.0.0
β”‚ └── pinkie@2.0.1
β”œβ”€β”¬ read-all-stream@3.0.1
β”‚ β”œβ”€β”¬ pinkie-promise@1.0.0
β”‚ β”‚ └── pinkie@1.0.0
β”‚ └─┬ readable-stream@2.0.4
β”‚   β”œβ”€β”€ core-util-is@1.0.2
β”‚   β”œβ”€β”€ inherits@2.0.1
β”‚   β”œβ”€β”€ isarray@0.0.1
β”‚   β”œβ”€β”€ process-nextick-args@1.0.5
β”‚   β”œβ”€β”€ string_decoder@0.10.31
β”‚   └── util-deprecate@1.0.2
β”œβ”€β”€ timed-out@2.0.0
β”œβ”€β”€ unzip-response@1.0.0
└─┬ url-parse-lax@1.0.0
  └── prepend-http@1.0.3

This decreases package size about 3x and improves installation time.

Callback API was dropped and Promises are default way to work with got now.

Important commits

Closes #130

@sindresorhus
Copy link
Owner

πŸ‘ Looks really good to me! When do we want to release this?

@sindresorhus
Copy link
Owner

Can you drop the inherits dependency from create-error-class? Just use normal JS subclassing with Object.create().

Can you do a scoped package @floatdrop/duplexer2 for sindresorhus/duplexer3@f770b34 ? I don't want us to depend on a git repo.

@floatdrop
Copy link
Contributor Author

Looks really good to me! When do we want to release this?

Thanks! I'm thinking about rc version to test changes, but have no idea when to publish major.

@sindresorhus
Copy link
Owner

Thanks! I'm thinking about rc version to test changes

πŸ‘ https://docs.npmjs.com/cli/dist-tag

floatdrop added a commit that referenced this pull request Jan 7, 2016
@floatdrop floatdrop merged commit fc3c2a5 into master Jan 7, 2016
@floatdrop floatdrop deleted the 6.0.0 branch January 7, 2016 16:29
@sindresorhus
Copy link
Owner

Yay! \o/

Super nice work on all this @floatdrop :)

celebration

@kevva
Copy link
Contributor

kevva commented Jan 7, 2016

⭐

Great job!

@floatdrop
Copy link
Contributor Author

a9peaa1_460sv mp4

@maxvipon
Copy link

πŸ”₯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants