-
-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Node.js 20 #2313
Require Node.js 20 #2313
Conversation
Hello @sindresorhus, I am surprised by this change, Node.js LTS 18.x is EOL in April 2025 and it is now not supported by The I am not asking you to reconsider, it's just disappointing to have dependant modules that rely on your modules such as this one forced to require a fresh out the oven LTS release if they wish to have their dependencies up to date. Can you shed some insight into this change? |
I usually strictly follow this convention of targeting the oldest active Node.js LTS version in my packages. However, this package is the exception because the HTTP part of Node.js is consistently buggy, and I don't have time to work around issues in older Node.js releases. If you need to still support Node.js 18, I suggest staying on Got v13, which is quite stable. This is also not the first time Got targets the latest Node.js version. I have done it many times before. It's also only 5 months until Node.js 20 is the oldest active LTS, so you can simply wait to upgrade until then. |
I'm aware of the workarounds. That just one of many things. I also have to provide support for Node.js 18 issues, and that takes time away from other things. |
Thank you for your thoughts @sindresorhus. |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [got](https://github.com/sindresorhus/got) | resolutions | major | [`^13.0.0` -> `^14.0.0`](https://renovatebot.com/diffs/npm/got/13.0.0/14.0.0) | --- ### Release Notes <details> <summary>sindresorhus/got (got)</summary> ### [`v14.0.0`](https://github.com/sindresorhus/got/releases/tag/v14.0.0) [Compare Source](sindresorhus/got@v13.0.0...v14.0.0) ##### Breaking - Require Node.js 20 ([#​2313](sindresorhus/got#2313)) [`a004263`](sindresorhus/got@a004263) - Why not target the oldest active Node.js LTS, which is Node.js 18? I usually strictly follow this convention in my packages. However, this package is the exception because the HTTP part of Node.js is consistently buggy, and I don't have time to work around issues in older Node.js releases. I you need to still support Node.js 18, I suggest staying on Got v13, which is quite stable. Node.js 18 will be out of active LTS in 5 months. ##### Improvements - Make `followRedirect` option accept a function ([#​2306](sindresorhus/got#2306)) [`7c3f147`](sindresorhus/got@7c3f147) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjAiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=--> Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/random-bunny/pulls/134 Co-authored-by: Renovate Bot <renovate@vylpes.com> Co-committed-by: Renovate Bot <renovate@vylpes.com>
No description provided.