Throw if request canceled and received incomplete response #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szmarczak
changed the title
szmarczak
commented
Apr 2, 2019
szmarczak
commented
Apr 2, 2019
szmarczak
commented
Apr 2, 2019
source/as-stream.ts
Outdated
| proxy._destroy = (error, callback) => { | ||
| // Stop transmitting data, | ||
| // so the stream won't have an `end` event. | ||
| output.destroy(); |
There was a problem hiding this comment.
The more elegant way would be to unpipe the response.
There was a problem hiding this comment.
We don't have to care about it. It will end if no error is provided, otherwise it will throw before ending.
tobenna
reviewed
Apr 3, 2019
tobenna
reviewed
Apr 3, 2019
Co-Authored-By: szmarczak <36894700+szmarczak@users.noreply.github.com>
|
Thanks for the review @tobenna It's very nice that you've had some time to take a look at this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #748