Add .isFromCache property to the stream API and rename the Promise API property from .fromCache to .isFromCache
#768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szmarczak
commented
Apr 2, 2019
sindresorhus
changed the title
fromCache property.fromCache property to the stream API
|
I would name it Is there any point in making it |
Sure. Should it be changed for Promises too?
It's undefined because we don't know is it true or false. I don't wanna make users mistaken. |
|
Yes, let’s change the Promise one too (forgot we had it there). |
szmarczak
changed the title
.fromCache property to the stream API.isFromCache property to the stream API
sindresorhus
changed the title
.isFromCache property to the stream API.isFromCache property to the stream API and rename the Promise API property from .fromCache to .isFromCache
|
👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #747
TODO: docs