Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the response as the second argument to the beforeRedirect hook #812

Merged
merged 4 commits into from Jun 24, 2019
Merged

Pass the response as the second argument to the beforeRedirect hook #812

merged 4 commits into from Jun 24, 2019

Conversation

clemyan
Copy link
Contributor

@clemyan clemyan commented May 28, 2019

Closes #810

The beforeRedirect hook will receive the original response (the one that has a 3xx status code) as the second argument.

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates.

@sindresorhus
Copy link
Owner

Hey, sorry, we just merged #797 which caused a lot of merge conflicts. Would you be able to fix the conflicts?

@clemyan
Copy link
Contributor Author

clemyan commented Jun 18, 2019

Hey, sorry, we just merged #797 which caused a lot of merge conflicts. Would you be able to fix the conflicts?

I will see what I can do after I get off work.

Should I rebase onto master and squash?

@sindresorhus
Copy link
Owner

You don’t need to squash, just rebase or pull from master.

@clemyan clemyan force-pushed the beforeredirect-response branch 2 times, most recently from e1ac8c6 to 4711841 Compare June 18, 2019 19:52
@sindresorhus sindresorhus changed the title Pass response to beforeRedirect hook Pass the response as the second argument to the beforeRedirect hook Jun 20, 2019
szmarczak
szmarczak approved these changes Jun 24, 2019
View reviewed changes
Copy link
Collaborator

@szmarczak szmarczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sindresorhus sindresorhus merged commit 3557896 into sindresorhus:master Jun 24, 2019
szmarczak pushed a commit to szmarczak/got that referenced this pull request Jun 25, 2019
@clemyan @szmarczak
Pass the response as the second argument to the beforeRedirect hook (…
cc422ec 
…sindresorhus#812)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

@szmarczak szmarczak szmarczak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass response to beforeRedirect hook
3 participants
@clemyan @sindresorhus @szmarczak