Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding possibility to set environment variables #54

Closed
wants to merge 5 commits into from
Closed

Adding possibility to set environment variables #54

wants to merge 5 commits into from

Conversation

herschel666
Copy link

Hi.

I need a possibility to set environment variables from inside the Gruntfile in an elegant way. I thought the options-object would be a nice place. What do you think?

Best regards!

@herschel666
Copy link
Author

Okay, this works on my local machine but unfortunately not on Travis. What would be the best way to deal with this situation? Omitting the test? Omitting the whole feature?? …

@@ -60,6 +61,7 @@ module.exports = function (grunt) {
args.push(options.router);
}

grunt.util._.extend(process.env, options.env);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. Just pass options.env to the env option in spawn.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not passing. Sorry for the hazzle!

@sindresorhus
Copy link
Owner

@herschel666 Can you fix the merge conflict?

Regarding the travis failure, just ignore it ;)

@kevva
Copy link
Contributor

kevva commented Mar 8, 2015

Could you also squash the commits?

@sindresorhus
Copy link
Owner

Thanks @herschel666 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants