1.0.0 is throwing errors #2

kevinrenskers · 2014-09-09T14:09:22Z

This is my gulp task:

gulp.task('less', function() {
    return gulp.src('src/assets/less/style.less')
        .pipe(plugins.sourcemaps.init())
        .pipe(plugins.less())
        .pipe(plugins.autoprefixer('last 2 versions'))
        .pipe(plugins.sourcemaps.write('./maps'))
        .pipe(gulp.dest('src/.tmp/styles'));
});

This worked fine with gulp-autoprefixer 0.0.10. After upgrading to 1.0.0 I am getting this error:

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: SourceMapGenerator.prototype.applySourceMap requires either an explicit source file, or the source map's "file" property. Both were omitted.
    at SourceMapGenerator_applySourceMap [as applySourceMap] (/Users/kevin/Workspace/sling-web/node_modules/gulp-autoprefixer/node_modules/vinyl-sourcemaps-apply/node_modules/source-map/lib/source-map/source-map-generator.js:170:17)
    at applySourceMap (/Users/kevin/Workspace/sling-web/node_modules/gulp-autoprefixer/node_modules/vinyl-sourcemaps-apply/index.js:11:15)
    at DestroyableTransform._transform (/Users/kevin/Workspace/sling-web/node_modules/gulp-autoprefixer/index.js:35:5)
    at DestroyableTransform.Transform._read (/Users/kevin/Workspace/sling-web/node_modules/gulp-autoprefixer/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:184:10)
    at DestroyableTransform.Transform._write (/Users/kevin/Workspace/sling-web/node_modules/gulp-autoprefixer/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:172:12)
    at doWrite (/Users/kevin/Workspace/sling-web/node_modules/gulp-autoprefixer/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:237:10)
    at writeOrBuffer (/Users/kevin/Workspace/sling-web/node_modules/gulp-autoprefixer/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:227:5)
    at DestroyableTransform.Writable.write (/Users/kevin/Workspace/sling-web/node_modules/gulp-autoprefixer/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:194:11)
    at write (/Users/kevin/Workspace/sling-web/node_modules/gulp-less/node_modules/through2/node_modules/readable-stream/lib/_stream_readable.js:623:24)
    at flow (/Users/kevin/Workspace/sling-web/node_modules/gulp-less/node_modules/through2/node_modules/readable-stream/lib/_stream_readable.js:632:7)

The text was updated successfully, but these errors were encountered:

battaglr · 2014-09-09T14:20:07Z

Autoprefixer have changed its API, know you need yo pass the browsers like this:

.pipe(autoprefixer({browsers: ['last 2 versions']}))

If you want, you can still use the v0.0.10.

kevinrenskers · 2014-09-09T14:38:22Z

Sadly that doesn't solve the problem, I still get the same error about "applySourceMap requires either an explicit source file, or the source map's "file" property".

sindresorhus · 2014-09-09T16:53:56Z

Can you try removing the less plugin and see if that changes anything?

kevinrenskers · 2014-09-09T20:52:44Z

Eh not really as I don't have valid css files, only Less files, sorry.

kevinrenskers · 2014-09-09T20:53:44Z

Ah wait I'll use a parsed version, d'oh :) Probably won't have time until tomorrow though.

sindresorhus · 2014-09-09T21:55:35Z

You also need to use the new method signature. See the readme.

iam-msm · 2014-09-09T22:23:57Z

With previous version there was no problem. But now
console msg =>
Error in plugin 'gulp-autoprefixer'
SourceMapGenerator.prototype.applySourceMap requires either an explicit source file......

when using this

gulp.task('less', function() {
  return gulp.src('tmp/less/**/*.less')
    .pipe($.changed('build/css', {extension: '.css'}))
    .pipe($.sourcemaps.init())
    .pipe($.plumber(onErrors))
    .pipe($.less())
    .pipe($.autoprefixer({browsers: AUTOPREFIXER_BROWSERS}))
    .pipe($.csscomb())
    .pipe($.sourcemaps.write('.'))
    .pipe(gulp.dest('build/css'))
    .pipe($.filter('**/*.css'))
    .pipe(reload({stream: true}))
});

But with pure css gulp-autoprefixer doing his job and also sourcemaps

gulp.task('less', function() {
  return gulp.src('build/css')
    .pipe($.sourcemaps.init())
    .pipe($.autoprefixer({browsers: AUTOPREFIXER_BROWSERS}))
    .pipe($.csscomb())
    .pipe($.sourcemaps.write('.'))
    .pipe(gulp.dest('build/css/testing'))
});

Also withoud gulp-autoprefixer task, gulp-less is doing his job

gulp.task('less', function() {
  return gulp.src('tmp/less/**/*.less')
    .pipe($.changed('build/css', {extension: '.css'}))
    .pipe($.sourcemaps.init())
    .pipe($.plumber(onErrors))
    .pipe($.less())
    .pipe($.csscomb())
    .pipe($.sourcemaps.write('.'))
    .pipe(gulp.dest('build/css'))
});

brandonb927 · 2014-09-10T07:59:00Z

Came here to voice my concern as well on this issue as I'm getting the same/a similar error message. It seems in my case is caused by autoprefixer

Gulp task

gulp.task('styles_compile', ['vendor_css', 'vendor_fonts'], function () {
  return gulp.src('src/styles/site.less')
    .pipe(sourcemaps.init())
    .pipe(less())
    .pipe(autoprefixer())
    .pipe(sourcemaps.write())
    .pipe(gulp.dest('public/assets/css'));
});

Stack trace

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: SourceMapGenerator.prototype.applySourceMap requires either an explicit source file, or the source map's "file" property. Both were omitted.
    at SourceMapGenerator_applySourceMap [as applySourceMap] (/project/path/node_modules/gulp-autoprefixer/node_modules/vinyl-sourcemaps-apply/node_modules/source-map/lib/source-map/source-map-generator.js:171:17)
    at applySourceMap (/project/path/node_modules/gulp-autoprefixer/node_modules/vinyl-sourcemaps-apply/index.js:11:15)
    at DestroyableTransform._transform (/project/path/node_modules/gulp-autoprefixer/index.js:35:5)
    at DestroyableTransform.Transform._read (/project/path/node_modules/gulp-autoprefixer/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:184:10)
    at DestroyableTransform.Transform._write (/project/path/node_modules/gulp-autoprefixer/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:172:12)
    at doWrite (/project/path/node_modules/gulp-autoprefixer/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:237:10)
    at writeOrBuffer (/project/path/node_modules/gulp-autoprefixer/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:227:5)
    at DestroyableTransform.Writable.write (/project/path/node_modules/gulp-autoprefixer/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:194:11)
    at write (/project/path/node_modules/gulp-less/node_modules/through2/node_modules/readable-stream/lib/_stream_readable.js:623:24)
    at flow (/project/path/node_modules/gulp-less/node_modules/through2/node_modules/readable-stream/lib/_stream_readable.js:632:7)

sindresorhus · 2014-09-10T09:53:20Z

Can you try putting console.log(file, file.sourceMap, res.map, res.map.toString()); above

gulp-autoprefixer/index.js

Line 35 in 3c8354f

applySourceMap(file, res.map.toString());

and paste in the output here?

dfaivre · 2014-09-10T21:23:25Z

Console output:

<File "app.css" <Buffer 62 6f 64 79 20 7b 0a 20 20 63 6f 6c 6f 72 3a 20 67 72 61 79 3b 0a 7d 0a>>
{ version: 3,
  sources: [ 'app.less' ],
  names: [],
  mappings: 'AAMA;EACE,WAAA',
  sourcesContent: [ '@mycolor: blue;\r\n\r\n.make-blue(@color) {\r\n  color: @color;\r\n}\r\n\r\nbody {\r\n  color: gray;\r\n}' ] }
{ _file: 'app.css',
  _sourceRoot: null,
  _sources: { _array: [ 'app.css' ], _set: { '$app.css': 0 } },
  _names: { _array: [], _set: {} },
  _mappings:
   [ { generatedLine: 1,
       generatedColumn: 0,
       originalLine: 1,
       originalColumn: 0,
       source: 'app.css',
       name: null },
     { generatedLine: 2,
       generatedColumn: 2,
       originalLine: 2,
       originalColumn: 2,
       source: 'app.css',
       name: null },
     { generatedLine: 2,
       generatedColumn: 15,
       originalLine: 2,
       originalColumn: 14,
       source: 'appcss',
       name: null },
     { generatedLine: 3,
       generatedColumn: 2,
       originalLine: 3,
       originalColumn: 1,
       source: 'app.css',
       name: null } ],
  _sourcesContents: null }
{"version":3,"sources":["app.css"],"names":[],"mappings":"AAAA;EACE,aAAY;EACb","file":"app.css"}

dfaivre · 2014-09-10T21:56:29Z

Looks like gulp-ng-annotate was having the same issue. Here's their workaround: Kagami/gulp-ng-annotate@2dd427d

That probalby won't work in this case, since the file.sourceMap.file property is already gone once it gets to gulp-autoprefixer. It could be an issue with vinyl-sourcemap-apply or it could be gulp-less not handling the gulp source map pipeline correctly?

sindresorhus · 2014-09-10T22:03:13Z

Thanks @dfaivre. I've opened a ticket here: gulp-sourcemaps/vinyl-sourcemaps-apply#1

chiefjester · 2014-09-15T05:14:16Z

this is happening to me as well:

gulp.task('less', function () {
  gulp.src(['./less/**/*.less', '!./less/**/_*.less'])
    .pipe(sourcemaps.init())
    .pipe(less())
    .pipe(prefix())
    .pipe(sourcemaps.write())
    .pipe(gulp.dest('./css'));
});

getting

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: SourceMapGenerator.prototype.applySourceMap requires either an explicit source file, or the source map's "file" property. Both were omitted.

chiefjester · 2014-09-19T08:26:21Z

@sindresorhus , the author of vinyl-sourcemap just said its not a bug on his end.
gulp-sourcemaps/vinyl-sourcemaps-apply#1

dfaivre · 2014-09-19T15:50:02Z

As a stopgap, I ended up created a custom gulp-autoprefixer that resets the file property before it tries to apply source maps:

res = autoprefixer(fileOpts).process(file.contents.toString(), {
                map: file.sourceMap ? {prev: file.sourceMap} : false,
                from: file.relative,
                to: file.relative
            });

            file.contents = new Buffer(res.css);

            if (res.map && file.sourceMap) {
                if (!(file.sourceMap.file)) {
                    file.sourceMap.file = file.relative;
                }
                applySourceMap(file, res.map.toString());
            }

Is this really an issue with gulp-less not setting the file.sourceMap.file property? Should all plugins have to guard against this?

sindresorhus · 2014-09-19T15:51:37Z

@dfaivre It's an gulp-less issue and will be fixed as soon as gulp-community/gulp-less#85 is merged.

chiefjester · 2014-09-20T18:50:16Z

@sindresorhus I just updated gulp-less to the one with gulp-community/gulp-less#85 and is now version 1.3.6.

It works but it throws a warning:
gulp-sourcemap-write: source file not found:/Users/xxx/...

If I remove gulp-autoprofexier plugin it works.

My current gulpfile.js

gulp.task('less', function () {
  gulp.src(['./assets/less/**/*.less', '!./assets/less/**/_*.less'])
    .pipe(sourcemaps.init())
    .pipe(less())
    .pipe(minifyCss())
    .pipe(prefix())
    .pipe(sourcemaps.write("./"))
    .pipe(gulp.dest('./assets/css'));
});

codekirei · 2014-09-20T21:58:41Z

@deezahyn Does this work for you, too? #3

koistya · 2014-09-21T07:19:29Z

var gulp = require('gulp');
var $ = require('gulp-load-plugins')();

gulp.task('styles', function () {
  return gulp.src(src/'styles/bootstrap.less')
    .pipe($.sourcemaps.init())
    .pipe($.less())
    .pipe($.autoprefixer())
    .pipe($.sourcemaps.write());
    .pipe(gulp.dest('./build/css'));
});

$ gulp styles
[11:13:47] Using gulpfile gulpfile.js
[11:13:47] Starting 'styles'...
gulp-sourcemap-write: source file not found: src\styles\bootstrap.css
[11:13:49] Finished 'styles' after 1.97 s

gulp-autoprefixer 1.0.1, gulp-less 1.3.6, gulp-sourcemaps 1.2.2, OS: Windows

chiefjester · 2014-09-21T07:28:04Z

@codekirei
Yes it removes the warning of "gulp-sourcemap-write: source file not found:" Not sure why you're PR seems failing the test.

- Current build seems to fail. It might have something to do with the default option Default: ['> 1%', 'last 2 versions', 'Firefox ESR', 'Opera 12.1'] which may change over time. - this commit updates the sourcemap file generated.

koistya · 2014-09-22T07:44:37Z

Same error with gulp-autoprefixer 1.0.1 Does anyone else have this issue? Or, maybe, it only takes place on Windows machines?

If I comment out .pipe($.autoprefix()) the error messages goes away.

gulp-sourcemaps/gulp-sourcemaps#37 (comment)

That error message means that:

sourcesContent for one of the files is missing

sourcemaps.write() tries to fix that by loading the content of the source file, but it can not find it
(probably because the path in sources is incorrect)

sebastian-steinmann · 2014-09-23T06:31:01Z

We have this issue too, and #3 seems to fix it for us.
(On windows)

It seems troubles caused by vinyl-sourcemaps-apply module. With this fix it just works.

battaglr closed this as completed Sep 9, 2014

battaglr reopened this Sep 9, 2014

sindresorhus mentioned this issue Sep 10, 2014

Loses source map file property gulp-sourcemaps/vinyl-sourcemaps-apply#1

Closed

sumerokr mentioned this issue Sep 12, 2014

sourceMappingURL not as expected gulp-community/gulp-less#72

Closed

fesor mentioned this issue Sep 18, 2014

Provide generated filename to associate with source map gulp-community/gulp-less#85

Merged

codekirei added a commit to codekirei/gulp-autoprefixer that referenced this issue Sep 20, 2014

Fix sindresorhus#2

190c17f

codekirei mentioned this issue Sep 20, 2014

Fix #2 #3

Closed

codekirei added a commit to codekirei/gulp-autoprefixer that referenced this issue Sep 23, 2014

Change res.from to fix sindresorhus#2

ab0a46d

codekirei added a commit to codekirei/gulp-autoprefixer that referenced this issue Sep 26, 2014

Add { prev: } option to read upstream sourcemaps; fixes sindresorhus#2

dde4a78

battaglr mentioned this issue Oct 3, 2014

How to use in combination with gulp-sass #8

Closed

battaglr added the sourcemaps label Oct 15, 2014

DenisIzmaylov added a commit to DenisIzmaylov/gulp-autoprefixer that referenced this issue Oct 17, 2014

Fix issue sindresorhus#2

d2be7ad

It seems troubles caused by vinyl-sourcemaps-apply module. With this fix it just works.

sindresorhus closed this as completed Apr 19, 2015

Nobody-x mentioned this issue Nov 16, 2021

Doesn't Play well with others jkulhanek/gulp-resolve-url#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1.0.0 is throwing errors #2

1.0.0 is throwing errors #2

kevinrenskers commented Sep 9, 2014

battaglr commented Sep 9, 2014

kevinrenskers commented Sep 9, 2014

sindresorhus commented Sep 9, 2014

kevinrenskers commented Sep 9, 2014

kevinrenskers commented Sep 9, 2014

sindresorhus commented Sep 9, 2014

iam-msm commented Sep 9, 2014

brandonb927 commented Sep 10, 2014

sindresorhus commented Sep 10, 2014

dfaivre commented Sep 10, 2014

dfaivre commented Sep 10, 2014

sindresorhus commented Sep 10, 2014

chiefjester commented Sep 15, 2014

chiefjester commented Sep 19, 2014

dfaivre commented Sep 19, 2014

sindresorhus commented Sep 19, 2014

chiefjester commented Sep 20, 2014

codekirei commented Sep 20, 2014

koistya commented Sep 21, 2014

chiefjester commented Sep 21, 2014

koistya commented Sep 22, 2014

sebastian-steinmann commented Sep 23, 2014

1.0.0 is throwing errors #2

1.0.0 is throwing errors #2

Comments

kevinrenskers commented Sep 9, 2014

battaglr commented Sep 9, 2014

kevinrenskers commented Sep 9, 2014

sindresorhus commented Sep 9, 2014

kevinrenskers commented Sep 9, 2014

kevinrenskers commented Sep 9, 2014

sindresorhus commented Sep 9, 2014

iam-msm commented Sep 9, 2014

brandonb927 commented Sep 10, 2014

sindresorhus commented Sep 10, 2014

dfaivre commented Sep 10, 2014

dfaivre commented Sep 10, 2014

sindresorhus commented Sep 10, 2014

chiefjester commented Sep 15, 2014

chiefjester commented Sep 19, 2014

dfaivre commented Sep 19, 2014

sindresorhus commented Sep 19, 2014

chiefjester commented Sep 20, 2014

codekirei commented Sep 20, 2014

koistya commented Sep 21, 2014

chiefjester commented Sep 21, 2014

koistya commented Sep 22, 2014

sebastian-steinmann commented Sep 23, 2014