Fix regressions in v7 #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Command failed with exit code 2 (ENOENT) when mocha is not installed globally.
They were piped into themselves.
sindresorhus
changed the title
|
Thanks for fixing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The upgrade to version 7.0.0 makes now use of execa option
localDir. The latter package does now the actual call tonpmRunPath.But in order for the change to be seemless in gulp-mocha, the option
preferLocalwhen calling execa must be set to true, otherwise the arrow functiongetEnvin execa will ignore it.Moreover
subprocess.stdout.pipe(subprocess.stdout);looked suspicious to me. I checked against gulp-mocha@6 and it used to be piped intoprocessstdios. So I replaced pipingsubprocessstdios into themselves by their piping intoprocessstdios.npm run testdidn't show any error after the changes, the 4 tests still pass.Fixes #196