Add createSubFolders option, default to true
#30
Conversation
|
Well, the Travis CI build is failing because the npm dependency for jszip was set to ^2.3.1, which won't exist until the JSZip devs publish the new version. Either I can revert the jszip dependency to 2.3.0 (as the changes I made will be benign in old versions) and get the Travis CI build to pass, and then update the version number again after JSZip publishes, or I can leave it as it is, in which case the Travis build will start working again as soon as 2.3.1 comes out. Let me know which you'd prefer. |
|
Why would there need to be an option for this? Seems like it can just be on by default unless I'm missing something. |
|
It is on by default. However, there are apparently use cases in JSZip where the behavior is undesirable, which is why I left a way for users to disable it if they need to. |
|
Use-cases like? |
|
Like this: Stuk/jszip#130 My pull request to JSZip has been accepted and merged into master, but I'm not sure when he'll re-publish the npm package. |
|
He's saying he'll re-publish the package later today, but he wants to change the name of the flag first, so let me update the code in this pull request real quick. |
|
Yeah, I don't really care about that usecase. Just enable it by default without an option. |
|
You da boss |
|
Okay, done - I also rebased all of the commits into one commit for easier merging and tracking |
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "gulp-zip", | |||
| "version": "0.4.0", | |||
| "version": "0.5.0", | |||
There was a problem hiding this comment.
don't bump other peoples versions. i have a bump script i run on publish time ;)
There was a problem hiding this comment.
My bad, I should have known better =)
|
Okay, done |
|
You were right about the JSZip version number, so I've updated the package.json file to require |
|
@isochronous see #31 |
|
Well, it's nice that it works without adding the option, but since the option is being added (stuk is going to publish it to npm as soon as he gets to a computer) it seems like that would be unnecessary complexity for something that can be addressed by just sending an option. But it's your call man, like I said before, you da boss. |
|
2.4.0 has been released |
The zip files generated by gulp-zip do not actually contain "real"
folders (that is, folders with the `D` attribute and `store` method).
Opening a zip with a GUI decompression utility shows folders, but
they're really "virtual" folders that are just defined by the path of
the files in the zip. Extracting the zips creates the actual folder
structure, but a decompression utility looking specifically for folders
won't find anything, as the `D` attribute is not present.
By sending {createFolders: true} as an option to JSZip's `.file` method,
true folders are created (with D attributes, method properties, etc) rather
than just virtual representations of folders that are part of the files'
paths.
This requires updating the required version of JSZip to 2.4.0.
Add `createSubFolders` option, default to `true`
I've got a PR (Stuk/jszip#157) in for JSZip to add a
createSubFoldersoption that will fix #29. This pull request just sends that option (defaulting to true if not provided) along to JSZip in each call to.file.