From 149333612364d1cafdc586ffa7b9a2b84a8da568 Mon Sep 17 00:00:00 2001 From: Seth Holladay Date: Tue, 4 May 2021 00:02:12 -0400 Subject: [PATCH] Fix merging of searchParams in ky.create() --- source/utils/merge.ts | 2 +- test/main.ts | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/source/utils/merge.ts b/source/utils/merge.ts index 871de4d8..977f16d7 100644 --- a/source/utils/merge.ts +++ b/source/utils/merge.ts @@ -49,10 +49,10 @@ export const deepMerge = (...sources: Array | undefined>): T => { if (isObject((source as any).headers)) { headers = mergeHeaders(headers, (source as any).headers); + returnValue.headers = headers; } } - returnValue.headers = headers; } return returnValue; diff --git a/test/main.ts b/test/main.ts index 4470b8a7..2a7eedf1 100644 --- a/test/main.ts +++ b/test/main.ts @@ -474,6 +474,18 @@ test('ky.create() with deep array', async t => { await server.close(); }); +test('ky.create() does not mangle search params', async t => { + const server = await createHttpTestServer(); + server.get('/', (request, response) => { + response.end(request.url); + }); + + const instance = ky.create({searchParams: {}}); + t.is(await instance.get(server.url, {searchParams: {}}).text(), '/?'); + + await server.close(); +}); + test('ky.extend()', async t => { const server = await createHttpTestServer(); server.get('/', (_request, response) => {