Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with the Spanish locale #7

Closed
mwanago opened this issue Sep 2, 2019 · 2 comments · Fixed by #8
Labels

Comments

@mwanago
Copy link
Contributor

@mwanago mwanago commented Sep 2, 2019

Hello
I'm experiencing issues with the Spanish locale.
In the mappings, there are two different codes for Spanish:

0x040a: "es_ES", # Spanish - Spain
0x0c0a: "es_ES", # Spanish - Spain (Modern)

The first one unfortunately doesn't work when calling the from method.

from(1034); // undefined
@sindresorhus

This comment has been minimized.

Copy link
Owner

@sindresorhus sindresorhus commented Sep 2, 2019

I must have missed that one when adopting the Python mapping. The current code in the package here doesn't account for there being multiple codes with the same label either, so it will need some refactoring.

@mwanago

This comment has been minimized.

Copy link
Contributor Author

@mwanago mwanago commented Sep 3, 2019

I will create a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.