Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added danger and question symbols #18

Closed
wants to merge 2 commits into from

Conversation

Berkmann18
Copy link

@Berkmann18 Berkmann18 commented Dec 7, 2018

I felt it that this package was missing some other log symbols such as the question mark one and the danger skull one (although that one isn't on code page 437 and don't have any "danger"/"death" related icons) so I opened this PR.

@Berkmann18
Copy link
Author

It seems that there's something wrong on v4 since both commits succeeded on both v6 and v8 but I notice this error on the v4 build:

> xo && ava
/home/travis/build/sindresorhus/log-symbols/node_modules/xo/cli-main.js:115
const {input, flags: opts} = cli;
      ^
SyntaxError: Unexpected token {
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:373:25)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/home/travis/build/sindresorhus/log-symbols/node_modules/xo/cli.js:15:2)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)

It seems that this error is relevant to xo and not this package.

Berkmann18 added a commit to Berkmann18/nclr that referenced this pull request Dec 7, 2018
Added symbols for `info`, `error` and `warning`. As for `question`, I submitted a
[PR](sindresorhus/log-symbols#18) that will hopefully get merged.
@sindresorhus
Copy link
Owner

What's the use-cases for these new icons?

@sindresorhus
Copy link
Owner

(although that one isn't on code page 437 and don't have any "danger"/"death" related icons)

The whole point of this package is to have good fallbacks for all the icons.

@Berkmann18
Copy link
Author

Berkmann18 commented Dec 8, 2018

The use case is that it will enable users to use more log symbols with other types of logs namely questions (e.g: for prompts or any thing labelled as a question).

The whole point of this package is to have good fallbacks for all the icons.

Makes sense, in this case the only addition would be the question one.

@sindresorhus
Copy link
Owner

But this package is meant for actual logging, not for arbitrary printing to the console, like a question prompt. I already have a package that includes symbols for any kind of use: https://github.com/sindresorhus/figures/blob/9d0895812c447617e35a47ac6200ad0ee1e9f2a0/index.js#L103

@Berkmann18
Copy link
Author

Fair enough.

Berkmann18 added a commit to Berkmann18/nclr that referenced this pull request Dec 11, 2018
Added symbols for `info`, `error` and `warning`. As for `question`, I submitted a
[PR](sindresorhus/log-symbols#18) that will hopefully get merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants