Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix v4.0.0 release notes #76

Closed
zaynv opened this issue Feb 5, 2018 · 1 comment
Closed

fix v4.0.0 release notes #76

zaynv opened this issue Feb 5, 2018 · 1 comment

Comments

@zaynv
Copy link

zaynv commented Feb 5, 2018

sorry for opening an issue about this, but not sure how else to inform.

The release notes showed this:


Before

const cli = meow(
	`
		Help text
	`,
	boolean: [
		'unicorn'
	],
	string: [
		'fooBar'
	],
	alias: {
		u: 'unicorn'
	},
	default: {
		foobar: 'foo'
	}
});

After

const cli = meow(
	`
		Help text
	`,
	flags: {
		unicorn: {
			type: 'boolean',
			alias: 'u'
		},
		fooBar: {
			type: 'string',
			default: 'foo'
		}
	}
});

However, I think the the outer object is missing.

For example,

const cli = meow(
	`
		Help text
	`,
	boolean: [
		'unicorn'
	],
	string: [
		'fooBar'
	],
	alias: {
		u: 'unicorn'
	},
	default: {
		foobar: 'foo'
	}
});

should be

const cli = meow(
	`
		Help text
	`,
        {
		boolean: [
			'unicorn'
		],
		string: [
			'fooBar'
		],
		alias: {
			u: 'unicorn'
		},
		default: {
			foobar: 'foo'
		}
        }
});

and same for the other place. i got a bit confused by this so thought it was worth mentioning

@sindresorhus
Copy link
Owner

Fixed. Thanks for letting me know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants