Check for all notifications page while opening new tab #170
Conversation
|
Already tested that it works, but pinging @RomanKornev for review anyway. Will merge in 24 hours or before if no more issues arise. |
| const currentWindow = true; | ||
| return browser.tabs.query({currentWindow, url}); | ||
| return browser.tabs.query({currentWindow, url: urlList}); |
There was a problem hiding this comment.
That still opens the default URL.
It correctly finds ?all=1 tab and reloads it to url which is default here:
There was a problem hiding this comment.
By definition, clicking on the extension icon should take you to the "notifications" page.
But when you have an "all notifications" page page or a "notifications" page open, this will take to the actual notifications page as intended by the click action on the extension icon.
Notifications page is where you generally go to find the recent/new notifications not the all notifications page.
There was a problem hiding this comment.
Can we add an option to customize that as well? Like "Use participating" that opens /participating but for ?all=1. So that clicking from anywhere would open all notifications.
There was a problem hiding this comment.
Well we would end up having a lot of options for each little thing if we think of them that way.
IMO this should be fine, and not that much of a problem as most of the time people work in "current notifications" page.
I'll merge this for now, but if you really think it seriously is, then feel free to open an issue, but we can not guarantee to add more behavior because of request from one person.
🤞
Closes #167