New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linkify commits - fixes #233 #234
Conversation
@@ -10,3 +13,27 @@ exports.readPkg = () => { | |||
|
|||
return pkg; | |||
}; | |||
|
|||
exports.linkifyIssues = (url, message) => { | |||
if (!supportsHyperlinks.stdout) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't experience any problems with leaving this out though. But maybe Windows renders the control characters...
package.json
Outdated
@@ -9,7 +9,7 @@ | |||
"node": ">=4" | |||
}, | |||
"scripts": { | |||
"test": "xo && ava" | |||
"test": "FORCE_HYPERLINK=1 xo && ava" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to make sure the hyperlinks
test also works in terminals which doesn't support hyperlinks.
This made me wonder, should AVA have a env
setting in package.json
like this? It just popped up when I had to do this.
{
"ava": {
"env": {
"FORCE_HYPERLINK": 1
}
}
}
This is odd, I enforce the hyperlinks but travis seems to fail... |
98d0ff8
to
15ff63b
Compare
Alright, was my own fault :). Should be ok now. |
✨This is super useful :) |
This PR implements #233. Feedback welcome. It also links the issues inside the commit.