Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preview mode #399

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@TiagoDanin
Copy link

commented May 3, 2019

Fixes #391

@TiagoDanin TiagoDanin force-pushed the TiagoDanin-Forks:preview.mode branch from dda6e8a to f4f3bf2 May 3, 2019

Show resolved Hide resolved source/cli.js Outdated
Show resolved Hide resolved source/cli.js Outdated
Show resolved Hide resolved source/index.js Outdated
Show resolved Hide resolved source/index.js Outdated
@@ -177,6 +180,7 @@ module.exports = async (input = 'patch', options) => {
tasks.add([
{
title: `Publishing package using ${pkgManagerName}`,
skip: () => options.preview,

This comment has been minimized.

Copy link
@itaisteinherz

itaisteinherz May 4, 2019

Collaborator

I'm not sure if the best way to implement this would be to simply skip the task.
I think this flag should be somewhat of a --verbsose flag as well, meaning that it should print out the exact commands it's going to run (e.g. npm version patch), as well as what made it decide to run those specific commands.
I'd like to see more opinions about this, though.

This comment has been minimized.

Copy link
@TiagoDanin

TiagoDanin May 4, 2019

Author

The commands could be printed in skip:
image

@TiagoDanin TiagoDanin force-pushed the TiagoDanin-Forks:preview.mode branch from b9e46c0 to 8c599e5 May 4, 2019

@TiagoDanin TiagoDanin force-pushed the TiagoDanin-Forks:preview.mode branch from 8c599e5 to 263cf7f May 4, 2019

Show resolved Hide resolved source/index.js Outdated
@TiagoDanin

This comment has been minimized.

Copy link
Author

commented May 5, 2019

image

@itaisteinherz

This comment has been minimized.

Copy link
Collaborator

commented May 6, 2019

This looks good, though I'm still not sure what the best way to handle #399 (comment) is.

// cc @sindresorhus @SamVerschueren Would love to hear your opinions here.

@itaisteinherz

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

@TiagoDanin It would be great if you could investigate into #391 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.