Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize skipping and enabling tasks #566

Merged
merged 1 commit into from Oct 4, 2020

Conversation

@sonicdoe
Copy link
Contributor

@sonicdoe sonicdoe commented Oct 3, 2020

Standardizes the behavior of skipping and enabling tasks as discussed in #513 (comment).

Apart from preview mode, there are now only two remaining cases where a task is skipped: “Pushing tags” when there’s no upstream branch (source) and when publishing failed (source). While the latter is certainly fine and expected, the former may be worthy of discussion. After all, the user may intentionally not have an upstream branch. For comparison, np also doesn’t skip “Running tests using npm” when there’s no test script.

Closes #513.

Most flags completely disable the task when explicitly specified (for example, `--no-cleanup` or `--no-tests` but also `--yolo`). This commit standardizes that behavior across all tasks. See #513 (comment).
@sindresorhus sindresorhus merged commit b519201 into sindresorhus:master Oct 4, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@sonicdoe sonicdoe deleted the sonicdoe:standardize-skipped branch Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.