Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSL: open fails due to quoting issue #165

Closed
radar opened this issue Jan 27, 2020 · 2 comments · Fixed by #166
Closed

WSL: open fails due to quoting issue #165

radar opened this issue Jan 27, 2020 · 2 comments · Fixed by #166

Comments

@radar
Copy link

radar commented Jan 27, 2020

Details

  • WSL Version: Ubuntu, Version 2
  • Open version: v7.0.0
  • Browser version: Firefox 73.0b9

Steps to reproduce

Open node, then:

const open = require("open")
open("http://localhost:3000", { wait: false })

What I expect to happen

The browser starts up, and opens localhost:3000

What actually happens:

image

Other information

This works with Open v6.3.0.

I suspect commit 7ef15d2 is to blame for this issue.

@radar
Copy link
Author

radar commented Jan 27, 2020

cc @Apochilles

@pluma
Copy link
Contributor

pluma commented Jan 28, 2020

Just tested this and removing the following line solves this issue:

target = `"${target}"`;

EDIT: Changing childProcessOptions.windowsVerbatimArguments seems to have no effect. I'm guessing this logic was intended only for Windows, not WSL.

EDIT2: Correct. The behavior works as intended on Windows but breaks in WSL. I'll create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants