Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the system xdg-open on Linux when open is bundled/packaged #134

Merged
merged 4 commits into from May 12, 2019

Conversation

@marcellourbani
Copy link
Contributor

@marcellourbani marcellourbani commented May 11, 2019

Just default to system xdg-open when __dirname = '/' on top of previous cases.

This happens when the code is packaged, as by default xdg-open is not included (and anyway wouldn't be in /)

Fixes #133

index.js Outdated Show resolved Hide resolved
@sindresorhus sindresorhus changed the title Fixes #133 use /xdg-open when packaged Use the system xdg-open on Linux when the Node.js module is bundled/packaged May 12, 2019
@sindresorhus sindresorhus changed the title Use the system xdg-open on Linux when the Node.js module is bundled/packaged Use the system xdg-open on Linux when open is bundled/packaged May 12, 2019
@sindresorhus sindresorhus merged commit c69fd06 into sindresorhus:master May 12, 2019
1 check passed
1 check passed
@travis-ci
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants