Add executable check for local xdg-open #140
Merged
Conversation
|
I would prefer using |
|
@sindresorhus Updated the PR, could you review? |
sindresorhus
merged commit 78fcc9e
into
sindresorhus:master
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Uses the executable package to ensure that the local/included
xdg-openis executable. If it's not executable (or there was some other error checking if it was executable, for exampleENOENT), it will fall back to systemxdg-openinstead.This allows for use within environments where
openthought it could run the bundledxdg-openbut it actually can't, such as in binaries produced by a node.js binary compiler like nbin.Inspired by #138 (comment).