Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app option on Windows #172

Merged
merged 2 commits into from Mar 9, 2020
Merged

Fix app option on Windows #172

merged 2 commits into from Mar 9, 2020

Conversation

@hong4rc
Copy link
Contributor

@hong4rc hong4rc commented Feb 28, 2020

Reopen #162

I moved check isWsl in if (!isWsl)

https://github.com/Hongarc/open/commit/3530dcd061498b597819fd21ed00282b082989dd

Should I keep check it in if(options.app)

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

@sindresorhus sindresorhus commented Mar 7, 2020

Have you manually tested this change?

@hong4rc
Copy link
Contributor Author

@hong4rc hong4rc commented Mar 7, 2020

Have you manually tested this change?

I used this code:

open('./test.js', {app: 'C:\\Program Files (x86)\\Google\\Chrome\\Application\\chrome.exe'})

success to open test.js file it in chrome

@hong4rc hong4rc requested a review from sindresorhus Mar 7, 2020
@sindresorhus sindresorhus changed the title Fix arg without double-quotes Fix app option on Windows Mar 9, 2020
@sindresorhus sindresorhus merged commit 30f4abe into sindresorhus:master Mar 9, 2020
1 check passed
1 check passed
@travis-ci
Travis CI - Pull Request Build Passed
Details
@hong4rc
Copy link
Contributor Author

@hong4rc hong4rc commented Mar 12, 2020

Fixed #158, it should be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants