Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indent option #96

Merged
merged 6 commits into from Feb 4, 2019
Merged

Add indent option #96

merged 6 commits into from Feb 4, 2019

Conversation

yaodingyd
Copy link
Contributor

Fix #23

One more try!

@sindresorhus
Copy link
Owner

Can you add it to https://github.com/sindresorhus/ora/blob/master/example.js to show it off in action?

@sindresorhus sindresorhus changed the title Add indent option Add indent option Feb 4, 2019
@sindresorhus
Copy link
Owner

Can you also allow changing the indent while Ora is running? Similar to how it's done in #95. Just add a public getter/setter and also validate that indent is an integer from 0 and up.

@sindresorhus
Copy link
Owner

Can you also document the indent property?

@yaodingyd
Copy link
Contributor Author

What other documentation is needed? I already added it in the README. So I need to expand on that?

@sindresorhus
Copy link
Owner

Right now it's documented as an option, but it needs to be documented as a property too. Here: https://github.com/sindresorhus/ora#color-1

@sindresorhus sindresorhus merged commit 24ebe3b into sindresorhus:master Feb 4, 2019
@sindresorhus
Copy link
Owner

Looks good :)

@sindresorhus
Copy link
Owner

You need to submit the PR URL to IssueHunt to claim the bounty. You can do this already when you open the PR. You don't have to wait until it's merged ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants