Add .isSpinning property

[xavdid]

Thought about expanding isSpinning to be

return this.enabled && this.id !== null;

since it can't be spinning if it's not enabled, but wasn't sure about the implications. That would simplify the check in start() to be if (this.isSpinning)

[SamVerschueren]

I'm wondering, if we name it isSpinning, shouldn't we make it a method instead? Either I think we should go with ora.spinning or ora.isSpinning().

[sindresorhus]

@SamVerschueren Why can only methods have the is-prefix? I always go with is for booleans no matter if they're properties or methods. I prefer properties for things that don't have side-effects or require a lot of computation. That's my general rule.

[SamVerschueren]

I'm fine with either though, I think it's more personal preference. Which is the case in programming almost all the time :).

[xavdid]

Cool! Name aside, is the code reasonable? Anything that I need to change?

[SamVerschueren]

Needs some docs to. Code looks good.

[xavdid]

@SamVerschueren updated!

[SamVerschueren]

By using the Returns word, it looks like it's a function returning something. Should we rather use something like

Retrieve the status of the spinner.

Short but describes what it does.

Or just leave it as is. This is really nitpicking :).

[xavdid]

Especially because the other functions end in parens, it's clear to me that this is a property not a function. Happy to change if you want, but if it were my choice I'd leave it. ¯\_(ツ)_/¯