New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not sort when sort is set to false. #155

Open
wants to merge 1 commit into
base: master
from

Conversation

1 participant
@vicapow

vicapow commented Sep 9, 2018

We cannot rely on () => {} as a no-op for sorting.

@vicapow

This comment has been minimized.

Show comment
Hide comment
@vicapow

vicapow Sep 10, 2018

For the most part, this should be backwards compatible unless you were setting sort: false and happen to be encoding parameters that were susceptible to this issue.

vicapow commented Sep 10, 2018

For the most part, this should be backwards compatible unless you were setting sort: false and happen to be encoding parameters that were susceptible to this issue.

@vicapow

This comment has been minimized.

Show comment
Hide comment
@vicapow

vicapow Sep 21, 2018

anything else you'd like me to tackle for this?

vicapow commented Sep 21, 2018

anything else you'd like me to tackle for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment