ensure correct parsing the query params with '='

[jhpoelen]

Expected:
http://someurl/?param=http%3A%2F%2Fsomeurl%3Fid%3D2837
should be parsed to:
{ param: 'http://someurl?id=2837' }
actual:
{ param: 'http://someurl?id' }

This change fixes that issue.

[sindresorhus]

No idea what your "fix" is doing, but it's not correct.

The reason it doesn't work is that supplying full URLs isn't supported yet: #15

[jhpoelen]

@sindresorhus Thanks for your quick response. I believe the issue is not related to the full url parsing: my example was a bit confusing... I would expect this test to pass:

it('query strings params including embedded `=`', function () {
    assert.deepEqual(qs.parse('?param=http%3A%2F%2Fsomeurl%3Fid%3D2837'), {param: 'http://someurl?id=2837'});
});

The actual result is { 'param': 'http://someurl?id' }.

I hope this clarifies the suggested fix.

[sindresorhus]

Your test seems to pass fine: https://travis-ci.org/sindresorhus/query-string/builds/64986110

Are you sure this is the query string lib you're using and you're using the latest version?

[jhpoelen]

@sindresorhus thanks for responding and adding the test. The issue was on my end - I wasn't encoding the url properly in the href attribute. I owe you a beer ; )