Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop `upload-button` feature #2014

Closed
bfred-it opened this issue May 6, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@bfred-it
Copy link
Collaborator

commented May 6, 2019

The feature is currently broken. It was initially added because we hide this bar via CSS:

However now we have two reasons why this is not useful:

  • upload-button now also takes care of hiding the bar; i.e. the feature can be disabled altogether and the bar reappears
  • we now also offer a CSS field to restore the bar

Additionally:

Therefore we can either:

  • 👎 Keep the feature as JS, but not add the alternative button
  • 👍 Drop the JS feature and just hide the bar via CSS (who doesn't want it can undo it easily in the custom CSS field)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.