Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approve / Reject buttons should show your current approval status #2537

Closed
ProLoser opened this issue Nov 12, 2019 · 1 comment
Closed

Approve / Reject buttons should show your current approval status #2537

ProLoser opened this issue Nov 12, 2019 · 1 comment

Comments

@ProLoser
Copy link

@ProLoser ProLoser commented Nov 12, 2019

Sometimes I double check if I've already approved a PR or if it was waiting for changes (with a rejection) or if I just made comments. It would be nice to not have to switch back to the comments page to see what the PRs current approval status is.
image

I was thinking if you already approved the PR, the 'approve' button appeared already pressed. Alternatively it would be nice to see the current 👍 👎 stats much like you see reactions to the left of the buttons:

1 (you) 👍 1 👎 [Comment] [Request Changes] [[Approve]]
or
[Comment] [Request Changes (1)] {Approve (you+1)}

@fregante

This comment has been minimized.

Copy link
Collaborator

@fregante fregante commented Nov 13, 2019

How do you end up on the Files tab without coming from the Discussion tab? Like, why are you there if you don’t know whether you need to review at all?

@fregante fregante closed this Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.