Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `link-to-file-in-file-history` feature #2000

Merged

Conversation

Projects
None yet
2 participants
@HardikModha
Copy link
Contributor

commented May 1, 2019

Closes #1979

The feature can be tested on

HardikModha added some commits May 1, 2019

Fix alignment issue
When the Verified badge is present for any commit, the buttons were
being pushed on the next line. Set the width auto for the container
which contains all these buttons.

@HardikModha HardikModha changed the title Add link to file in file history view Add `link-to-file-in-file-history` feature May 1, 2019

@HardikModha HardikModha force-pushed the HardikModha:add_link_to_file_in_file_history_view branch from d4f31cc to dcb74ca May 1, 2019

@bfred-it bfred-it added the enhancement label May 3, 2019

Show resolved Hide resolved source/libs/page-detect.ts Outdated
Show resolved Hide resolved source/features/link-to-file-in-file-history.tsx Outdated
Show resolved Hide resolved source/features/link-to-file-in-file-history.tsx Outdated
Show resolved Hide resolved source/features/link-to-file-in-file-history.tsx Outdated

@bfred-it bfred-it self-assigned this May 5, 2019

@bfred-it bfred-it removed their assignment May 5, 2019

Fix container width
I was hoping to set something like `fit-content` but it doesn't seem to work

@bfred-it bfred-it merged commit ad17f06 into sindresorhus:master May 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bfred-it

This comment has been minimized.

Copy link
Collaborator

commented May 5, 2019

2000

@bfred-it bfred-it referenced this pull request May 18, 2019

Closed

Refined GitHub updates #1137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.