Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arrow-up support when choosing labels in a PR #2008

Open
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@idasbiste
Copy link
Contributor

commented May 3, 2019

This feature adds support for cycled list navigation with keyboard support when choosing labels for PRs.
The PR closes #1450 (I saw the project had an older but closed PR so I thought I could give it another try).

@bfred-it bfred-it self-requested a review May 4, 2019

@bfred-it bfred-it added the enhancement label May 4, 2019

@sindresorhus

This comment has been minimized.

Copy link
Owner

commented May 6, 2019

Why limit it to labels? Could be applied to any list popover, like Reviewers, Assignees, Project, Milestones, etc.

@bfred-it bfred-it removed their request for review May 11, 2019

@idasbiste

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2019

@sindresorhus I limited it to labels because of the issue but I'm more than happy to extend it to the other lists! 👍

Repository owner deleted a comment May 12, 2019

Eduardo Fernandes added some commits May 12, 2019

@bfred-it
Copy link
Collaborator

left a comment

Merge with master, it needs a description field because of #2030

Eduardo Fernandes added some commits May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.