Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test , ignore ? #2010

Closed
wants to merge 222 commits into from

Conversation

Projects
None yet
@bfred-it
Copy link
Collaborator

commented May 5, 2019

No description provided.

vinkla and others added some commits Feb 14, 2019

Drop `op-labels` feature (#1776)
It has been implemented by GitHub
Refresh the options view (#1777)
* Drop the options popup

* Improve Firefox style

* Change order, copy, drop some separators
Warn users when they attempt to create a PR from default branch (#1758)
Co-authored-by: Federico Brigante <github@bfred.it>
Drop WIP PRs extension from Related section in readme (#1785)
WIP PRs are now offered natively by GitHub.
@bfred-it

This comment has been minimized.

Copy link
Collaborator Author

commented on package.json in 7e05e8f Feb 18, 2019

The latest version actually doesn't work:

https://travis-ci.org/sindresorhus/refined-github/builds/494731517

> xo && stylelint source/*.css
TypeError: Cannot read property 'resolvedReturnType' of undefined
    at Object.getReturnTypeOfSignature (/home/travis/build/sindresorhus/refined-github/node_modules/typescript/lib/typescript.js:38422:28)
    at validateNode (/home/travis/build/sindresorhus/refined-github/node_modules/@typescript-eslint/eslint-plugin/lib/rules/promise-function-async.js:91:34)
    at FunctionExpression (/home/travis/build/sindresorhus/refined-github/node_modules/@typescript-eslint/eslint-plugin/lib/rules/promise-function-async.js:120:11)
    at listeners.(anonymous function).forEach.listener (/home/travis/build/sindresorhus/refined-github/node_modules/xo/node_modules/eslint/lib/util/safe-emitter.js:45:58)
    at Array.forEach (<anonymous>)
    at Object.emit (/home/travis/build/sindresorhus/refined-github/node_modules/xo/node_modules/eslint/lib/util/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/home/travis/build/sindresorhus/refined-github/node_modules/xo/node_modules/eslint/lib/util/node-event-generator.js:251:26)
    at NodeEventGenerator.applySelectors (/home/travis/build/sindresorhus/refined-github/node_modules/xo/node_modules/eslint/lib/util/node-event-generator.js:280:22)
    at NodeEventGenerator.enterNode (/home/travis/build/sindresorhus/refined-github/node_modules/xo/node_modules/eslint/lib/util/node-event-generator.js:294:14)
    at CodePathAnalyzer.enterNode (/home/travis/build/sindresorhus/refined-github/node_modules/xo/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:632:23)

@sindresorhus

This comment has been minimized.

Copy link
Owner

replied Feb 18, 2019

See: typescript-eslint/typescript-eslint#227

typescript-eslint/typescript-eslint#287 is about to land, which fixes it, so I was just holding out on that.

This comment has been minimized.

Copy link
Collaborator Author

replied Feb 18, 2019

Argh, I didn't realize that 0.7.0 was also not passing validation and pushed that instead of 0.8.0.

Fixed now: 673b900

I'll let #1783 fix the new errors where needed.

bfred-it and others added some commits Feb 18, 2019

Show warning when user attempts to disable PR edits (#1770)
Co-authored-by: Federico Brigante <github@bfred.it>

bfred-it and others added some commits Apr 25, 2019

Add `link-to-file-in-file-history` feature (#2000)
Co-authored-by: Federico Brigante <github@bfred.it>

@bfred-it bfred-it closed this May 5, 2019

@bfred-it bfred-it reopened this May 5, 2019

@bfred-it bfred-it closed this May 5, 2019

@bfred-it bfred-it reopened this May 5, 2019

@bfred-it bfred-it closed this May 5, 2019

@bfred-it bfred-it changed the title test, ignore test, ignore May 5, 2019

@bfred-it bfred-it changed the title test, ignore test , ignore May 5, 2019

@bfred-it bfred-it changed the title test , ignore sdftest , ignore May 5, 2019

@bfred-it bfred-it changed the title sdftest , ignore test , ignore May 5, 2019

@bfred-it bfred-it changed the title test , ignore test , ignore ? May 5, 2019

@zachwhaley

This comment has been minimized.

Copy link

commented on 9be9440 May 6, 2019

Are there plans to bring this back? My team used this feature :(

This comment has been minimized.

Copy link
Collaborator Author

replied May 6, 2019

No, but it's a relatively simple feature you can rebuild as a userscript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.