Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `clean-sidebar` feature #2011

Merged
merged 10 commits into from May 6, 2019

Conversation

Projects
None yet
2 participants
@bfred-it
Copy link
Collaborator

commented May 5, 2019

Closes #421 (hide milestones)
Closes #977 (hide projects)
Replaces and closes #1945
Replaces and closes #1965

The code is ugly but sadly each section is at least slightly different :( β†’ ceeca8d 🌈

Tests

Depends on many variables:

  • issues/PRs
  • empty/full sections
  • can/cannot edit sections

These have a good variety of PR + cannot edit sections: https://github.com/parcel-bundler/parcel/pulls

Tasks

  • Handle sidebar ajax updates
  • Adjust spacing
  • Documentation

Screenshots (WIP)

Screenshot 2019-05-06 at 03 32 53 Screenshot 2019-05-06 at 03 33 01

@bfred-it bfred-it added the enhancement label May 5, 2019

@bfred-it bfred-it requested a review from sindresorhus May 5, 2019

bfred-it added some commits May 5, 2019

@bfred-it

This comment has been minimized.

Copy link
Collaborator Author

commented May 5, 2019

This is ready!

@sindresorhus

This comment has been minimized.

Copy link
Owner

commented May 6, 2019

In yannickcr/eslint-plugin-react#2261, shouldn't it remove the empty headings?

Screen Shot 2019-05-06 at 14 05 32

@bfred-it

This comment has been minimized.

Copy link
Collaborator Author

commented May 6, 2019

Fixed

@bfred-it bfred-it merged commit 4bc3f3a into master May 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bfred-it bfred-it deleted the clean-sidebar branch May 6, 2019

@bfred-it bfred-it referenced this pull request May 18, 2019

Closed

Refined GitHub updates #1137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.