Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `wait-for-build` #2023

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
None yet
1 participant
@bfred-it
Copy link
Collaborator

commented May 11, 2019

Fixes #1792

Tested in Chrome and Firefox

@bfred-it bfred-it added the bug label May 11, 2019

@bfred-it bfred-it referenced this pull request May 12, 2019

Merged

Reliable merge box handlers #2019

1 of 2 tasks complete
@bfred-it

This comment has been minimized.

Copy link
Collaborator Author

commented May 13, 2019

Tested again in Chrome for:

  • new commit appears (submission is cancelled)
  • ci fails (submission is cancelled)
  • ci succeeds (PR is merged)
  • cancel and click "merge" multiple times (it keeps waiting and then merges)

@bfred-it bfred-it merged commit 09d1ab6 into master May 13, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bfred-it bfred-it deleted the ci-status-fix branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.