Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide `link-to-file-in-file-history` where not needed #2025

Merged

Conversation

Projects
None yet
2 participants

dotconnor added some commits May 11, 2019

@bfred-it

This comment has been minimized.

Copy link
Collaborator

commented May 11, 2019

The condition above was meant to do this, so you can replace it

@dotconnor

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2019

@bfred-it I'm sorry can you explain?

Repository owner deleted a comment May 12, 2019

@bfred-it

This comment has been minimized.

Copy link
Collaborator

commented May 12, 2019

I mean the condition on line 17 was supposed to do what you’re trying to do now (disable the feature on branch Commits page), but it doesn’t work, so you can drop it.

@bfred-it bfred-it changed the title disable file history buttons on branch commit pages Hide `link-to-file-in-file-history` where not needed May 12, 2019

@bfred-it bfred-it added the bug label May 12, 2019

@bfred-it bfred-it merged commit 078f47d into sindresorhus:master May 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bfred-it

This comment has been minimized.

Copy link
Collaborator

commented May 12, 2019

Thanks @dotconnor 🧧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.