Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `open-issue-to-latest-comment` feature #2028

Merged
merged 19 commits into from May 21, 2019

Conversation

Projects
None yet
2 participants
@dotconnor
Copy link
Contributor

commented May 12, 2019

Closes #1969

dotconnor added some commits May 12, 2019

add delay to scroll
For some reason Github will scroll to the top after we've scolled down to the last comment

@dotconnor dotconnor changed the title Open issue to latest comment Add `open-issue-to-latest-comment` feature May 12, 2019

Show resolved Hide resolved .github/CODEOWNERS Outdated
Show resolved Hide resolved source/features/open-issue-to-latest-comment.tsx Outdated
Show resolved Hide resolved source/features/open-issue-to-latest-comment.tsx Outdated
Show resolved Hide resolved source/features/open-issue-to-latest-comment.tsx Outdated

dotconnor added some commits May 13, 2019

Show resolved Hide resolved source/features/open-issue-to-latest-comment.tsx Outdated
Show resolved Hide resolved source/libs/page-detect.ts Outdated
Show resolved Hide resolved source/features/open-issue-to-latest-comment.tsx Outdated

dotconnor and others added some commits May 13, 2019

Update source/features/open-issue-to-latest-comment.tsx
Co-Authored-By: Federico Brigante <github@bfred.it>
@bfred-it

This comment has been minimized.

Copy link
Collaborator

commented May 13, 2019

I think this is almost good to go:

  • Merge with master, it needs a description field because of #2030
  • Mention the feature in the readme under the shortcuts

dotconnor added some commits May 13, 2019

Show resolved Hide resolved .github/CODEOWNERS Outdated
readme.md Outdated
@@ -206,6 +206,7 @@ GitHub Enterprise is also supported. More info in the options.
- [Search or select tags from a dropdown in the `Releases` page.](https://user-images.githubusercontent.com/22439276/56373231-27ee9980-621e-11e9-9b21-601919d3dddf.png)
- [Link to file itself in the history pages](https://user-images.githubusercontent.com/22439276/57195061-b88ddf00-6f6b-11e9-8ad9-13225d09266d.png)
- [See an automatic changelog for each tag or release.](https://user-images.githubusercontent.com/1402241/57081611-ad4a7180-6d27-11e9-9cb6-c54ec1ac18bb.png)
- [Quickly open to the latest comment](https://user-images.githubusercontent.com/14323370/57660122-02517780-75b3-11e9-9370-4c0426b248ca.gif)

This comment has been minimized.

Copy link
@bfred-it

bfred-it May 17, 2019

Collaborator
Suggested change
- [Quickly open to the latest comment](https://user-images.githubusercontent.com/14323370/57660122-02517780-75b3-11e9-9370-4c0426b248ca.gif)
- [Open issues to the latest comment by clicking the comments icon.](https://user-images.githubusercontent.com/14323370/57660122-02517780-75b3-11e9-9370-4c0426b248ca.gif)

This can just be a screenshot that focuses on that button on the right, not a gif.

This comment has been minimized.

Copy link
@bfred-it

bfred-it May 18, 2019

Collaborator

This is still a gif

This comment has been minimized.

Copy link
@dotconnor

dotconnor May 18, 2019

Author Contributor

My bad, I thought the suggestion was just the description change.

Show resolved Hide resolved source/features/open-issue-to-latest-comment.tsx Outdated
@bfred-it

This comment has been minimized.

Copy link
Collaborator

commented May 17, 2019

Once these are in it can be merged

dotconnor and others added some commits May 17, 2019

Update .github/CODEOWNERS
Co-Authored-By: Federico Brigante <github@bfred.it>
Update readme.md
Co-Authored-By: Federico Brigante <github@bfred.it>
Update source/features/open-issue-to-latest-comment.tsx
Co-Authored-By: Federico Brigante <github@bfred.it>

@bfred-it bfred-it merged commit 884b362 into sindresorhus:master May 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bfred-it

This comment has been minimized.

Copy link
Collaborator

commented May 21, 2019

Thank you 🙏

@dotconnor dotconnor deleted the dotconnor:open-issue-to-latest-comment branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.