Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `scroll-to-top-on-collapse` feature #2036

Merged
merged 2 commits into from May 18, 2019

Conversation

Projects
None yet
2 participants
@notlmn
Copy link
Contributor

commented May 13, 2019

Closes #2033

@bfred-it bfred-it added the cleanup label May 13, 2019

@bfred-it
Copy link
Collaborator

left a comment

The readme also needs to be updated (moved from the original section to "previously part of RGH")

@notlmn

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

@bfred-it The feature was never mentioned in the readme 🤷‍♂️.

@bfred-it

This comment has been minimized.

Copy link
Collaborator

commented May 13, 2019

Indeed: e6cc50f

It may be worth adding to the "Previously part of" if we care about that.

@bfred-it

This comment has been minimized.

Copy link
Collaborator

commented May 18, 2019

Can you fix the conflicts?

@bfred-it bfred-it merged commit 88fc1e2 into sindresorhus:master May 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@notlmn notlmn deleted the notlmn:drop-scroll-to-top-on-collapse branch May 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.