Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format titles on single issue / PR pages #2110

Merged

Conversation

Projects
None yet
3 participants
@bfred-it
Copy link
Collaborator

left a comment

The title can be format-discussion-titles

Show resolved Hide resolved source/features/linkify-issues-in-titles.tsx Outdated

HardikModha added some commits Jun 2, 2019

@bfred-it
Copy link
Collaborator

left a comment

Looks great! Thanks a lot for the playground issues :)

I'd like to see an updated readme and a screenshot:

  1. with this title: Highlights any code and references like #1 in the titles
  2. Retina or zoomed in at 200%
  3. cropped like:
    Screenshot 2019-06-05 at 02 34 40
@HardikModha

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

Not related to this, But when I was working on this feature I noticed this,

Screen Shot 2019-06-02 at 3 32 22 PM

It is not misaligned but it looks like it is because the text is always kept on right. Can we keep the text left aligned?

@bfred-it

This comment has been minimized.

Copy link
Collaborator

commented on readme.md in 945386c Jun 5, 2019

I can’t find it, but was the previous feature not mentioned on the readme? linkify-issue-titles

@HardikModha

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

I couldn't find it. Seems like it was added 767791e#diff-0730bb7c2e8f9ea2438b52e419dd86c9R13 but later removed accidentally in 3298fc7#diff-0730bb7c2e8f9ea2438b52e419dd86c9L35

@bfred-it

This comment has been minimized.

Copy link
Collaborator

commented Jun 5, 2019

Ah, indeed. It's now part of the Highlights:

Clickable references to issues and pull requests

@bfred-it

This comment has been minimized.

Copy link
Collaborator

commented Jun 5, 2019

The screenshot can stay in the feature but the readme already mentions this feature in two parts, so I dropped it from there:

  • Clickable references to issues and pull requests
  • Text wrapped in backticks in issue titles and commit titles is highlighted
@bfred-it

This comment has been minimized.

Copy link
Collaborator

commented Jun 5, 2019

Thanks for the PR! 🌠

At some point I'd probably want to see a full formatText() function that can be used across the extension (here, parse-backticks, options.tsx, etc)

@bfred-it bfred-it merged commit 6effe10 into sindresorhus:master Jun 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@HardikModha HardikModha deleted the HardikModha:parse_backticks_in_issue_titles branch Jun 5, 2019

@HardikModha

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

Sorry but didn't get what you meant by this. parseBackticks is already being used in options.tsx. What this formatText function do additionally? Will it take care of backticks as well as links?

@HardikModha

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

Not related to this, But when I was working on this feature I noticed this,

Screen Shot 2019-06-02 at 3 32 22 PM

It is not misaligned but it looks like it is because the text is always kept on right. Can we keep the text left aligned?

Also, What do you think about this?

@bfred-it

This comment has been minimized.

Copy link
Collaborator

commented Jun 5, 2019

I put a like on that, it means yes 😃

@notlmn

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

If I'm not wrong, I think at some point parse-backticks feature can be merged into this, renaming this to format-titles, for formatting titles across discussion lists, issues/PRs, conflicts page, and possibly other pages, all in a single place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.