Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `clean-issue-filters` feature #2114

Merged
merged 8 commits into from Jun 7, 2019

Conversation

Projects
None yet
5 participants
@notlmn
Copy link
Contributor

commented Jun 3, 2019

Closes #2016.

Test

@notlmn

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

Also thought of adding support for repo deployment status, but that requires another API request (one to get latest commit, and one to get its deployment status). And targeting status dropdown is a bit of problem too.

Show resolved Hide resolved source/libs/utils.ts Outdated
Use `unknown` instead of `any`.
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
Show resolved Hide resolved source/features/clean-issue-filters.tsx Outdated
Show resolved Hide resolved source/features/clean-issue-filters.tsx
Show resolved Hide resolved source/features/clean-issue-filters.tsx Outdated
Show resolved Hide resolved source/features/clean-issue-filters.tsx Outdated
Show resolved Hide resolved source/features/clean-issue-filters.tsx Outdated
@bfred-it
Copy link
Collaborator

left a comment

Can you add the feature to the readme and add yourself to CODEOWNERS?

  1. Zoom at 200% (or have a retina display)
  2. Reuse this format and its arrows (copy-paste them): https://user-images.githubusercontent.com/1402241/55069759-bceaf080-50bf-11e9-84d0-7707de2eb9e9.png

Also it would be good to cache the result of this, per-repo, especially with #2109 coming :)

If not impossible, it would be nice to also drop the Checks selector. Does the API include that?

Show resolved Hide resolved source/features/clean-issue-filters.tsx Outdated
@notlmn

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

If not impossible, it would be nice to also drop the Checks selector. Does the API include that?

Took me a while to debug, but that's part of filter-pr-by-build-status. The dropdown doesn't exist until that features adds it, maybe it's better to handle this in that feature.


Also it would be good to cache the result of this, per-repo, especially with #2109 coming :)

Let's deal with that in a separate PR. Or will have to wait until #2109 is merged.

notlmn added some commits Jun 7, 2019

@bfred-it

This comment has been minimized.

Copy link
Collaborator

commented Jun 7, 2019

The dropdown doesn't exist until that features adds it, maybe it's better to handle this in that feature.

D’oh, I forgot about that

}
user(login: "${ownerName}") {
projects { totalCount }
}

This comment has been minimized.

Copy link
@bfred-it

bfred-it Jun 7, 2019

Collaborator

Apparently even if I have a personal project, public, with an issue from the current repo inside, the dropdown is still empty for me.

I dropped this

@bfred-it bfred-it changed the title Cleanup issue and PR filters Add `clean-issue-filters` feature Jun 7, 2019

@bfred-it bfred-it merged commit f19e54b into sindresorhus:master Jun 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@FloEdelmann

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

Thanks @notlmn! 😊

@bfred-it

This comment has been minimized.

Copy link
Collaborator

commented Jun 7, 2019

It does look much better now!

@notlmn notlmn deleted the notlmn:clean-issue-filters branch Jun 7, 2019

@notlmn

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

If not impossible, it would be nice to also drop the Checks selector. Does the API include that?

Took me a while to debug, but that's part of filter-pr-by-build-status. The dropdown doesn't exist until that features adds it, maybe it's better to handle this in that feature.

Opened #2127 to track this.

@yakov116

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

@notlmn nothing major but

❌ clean-issue-filters
content.js:2111 TypeError: Cannot read property 'parentElement' of null
    at clean_issue_filters_init (content.js:6423)
    at async features_run (content.js:2106)

When a repo has not Issues or Pull requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.