Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `limit-commit-title-length` feature #2115

Merged
merged 17 commits into from Jun 23, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Add tests for `isEditingFile`

  • Loading branch information...
notlmn committed Jun 3, 2019
commit 71a3ab51701f75c81d35c4116632d108691bce60
@@ -391,3 +391,11 @@ test('isSingleTagPage', urlMatcherMacro, pageDetect.isSingleTagPage, [
'https://github.com/sindresorhus/refined-github',
'https://github.com/sindresorhus/refined-github/graphs'
]);

test('isEditingFile', urlMatcherMacro, pageDetect.isEditingFile, [
'https://github.com/sindresorhus/refined-github/edit/master/readme.md',
'https://github.com/sindresorhus/refined-github/edit/ghe-injection/source/background.ts',
], [
'https://github.com/sindresorhus/refined-github',
'https://github.com/sindresorhus/refined-github/pulls'
This conversation was marked as resolved by notlmn

This comment has been minimized.

Copy link
@bfred-it

bfred-it Jun 4, 2019

Collaborator

Negative tests need to include some tricky urls like a user called edit, a repo called edit, a file called edit and so on

This comment has been minimized.

Copy link
@notlmn

notlmn Jun 4, 2019

Author Contributor

Done! 😊

])
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.