Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show `filter-pr-by-build-status` if the repo has CI #2133


None yet
2 participants
Copy link

commented Jun 7, 2019

Closes #2127


  1. (Filter should be present)
  2. (Filters should not be present)

HardikModha added some commits Jun 7, 2019

if (!ciStatusIcon) {
return false;

const reviewsFilter = select('.table-list-header-toggle > details:nth-last-child(3)')!;

This comment has been minimized.

Copy link

bfred-it Jun 7, 2019


Since #2114 removed some filters, we might need to change the way we find the position.

It may work before this PR because this check is added before clean-issue-filters runs

This comment has been minimized.

Copy link

HardikModha Jun 7, 2019

Author Contributor

Hey, "Assignee" and "Sort" filters are always there at the last and they are not getting removed. So this approach won't break. .table-list-header-toggle > details:nth-last-child(3) will still work.

@bfred-it bfred-it changed the title Hide status filter for PR list if there are no checks Only show `filter-pr-by-build-status` if the repo has CI Jun 8, 2019

@bfred-it bfred-it merged commit 8ae8e88 into sindresorhus:master Jun 8, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress

This comment has been minimized.

Copy link

commented Jun 8, 2019

Thanks for the quick fix @HardikModha ⚡️

@HardikModha HardikModha deleted the HardikModha:filter_pr_build_status_for_ci_enabled_repo branch Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.