Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align `add-asset-download-count` with asset size #2136

Closed

Conversation

Projects
None yet
3 participants
@dotconnor
Copy link
Contributor

commented Jun 8, 2019

@sindresorhus

This comment has been minimized.

Copy link
Owner

commented Jun 8, 2019

I think it’s should be vertically aligned by the icons, not the number.

@dotconnor

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

ezgif-1-2208b23d610e

  1. Moves icon, download count and size all to the same parent with align-items: center
  2. Applied align-items: center to all download container and parent container (this pr)
  3. Moves icon, download count and size all to the same parent and removes flex, applies vertical-align: middle to the icon
  4. Moves icon, download count and size all to the same parent and removes flex, applies line-height: 16; height: 16px to text

I'd go with 1 or 4

@bfred-it

This comment has been minimized.

Copy link
Collaborator

commented Jun 9, 2019

See #2139

@bfred-it bfred-it removed their assignment Jun 9, 2019

@@ -121,6 +121,6 @@ import './features/hide-readme-header.css';
import './features/hide-obvious-tooltips.css';
import './features/clean-discussions.css';
import './features/clean-rich-text-editor.css';

import './features/show-asset-download-count.css';

This comment has been minimized.

Copy link
@bfred-it

bfred-it Jun 9, 2019

Collaborator

By the way only CSS-only features should be added here; JS features should import their own CSS file. Refer to my implementation of this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.