Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build time #2199

Merged
merged 5 commits into from Jul 7, 2019

Conversation

Projects
None yet
4 participants
@bfred-it
Copy link
Collaborator

commented Jul 1, 2019

Closes #1937

I disabled stats: 'errors-only' to have webpack say exactly how long it takes for the build.

I tried incremental: true in tsconfig.json but it had no effect. From what I understand, this currently only works when using tsc without extra build tools, since they haven't added any APIs for it yet.

npm run build

Before After
~6s ~5s

npm run watch (updates)

Before After
~3.5s ~0.5s 馃槏

IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

@bfred-it bfred-it added the meta label Jul 1, 2019

bfred-it added some commits Jul 1, 2019

@jerone

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

I disabled stats: 'errors-only' to have webpack say exactly how long it takes for the build.

I'm currently using this is my webpack.config.js:

	stats: {
		all: false,
		errors: true,
		moduleTrace: true,
		builtAt: true
	},
@bfred-it

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 6, 2019

Webpack still shows a lot of useless information, instead of trying to filter it we decided to just use the SizePlugin

@jerone

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2019

@bfred-it commented on Jul 6, 2019, 6:19 AM GMT+2:

Webpack still shows a lot of useless information, instead of trying to filter it we decided to just use the SizePlugin

Only thing missing from that is a timestamp, to know that the build actually happened. For example when the build fails, what errors belong to this build and which errors belong to the previous build. But maybe thats for another issue.

@bfred-it

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 7, 2019

I added the build-at date as you suggested 馃憤

I learned 2 things about the fork plugin:

  • it already uses the --incremental flag
  • it also shows the build time

It also shows some extra useless information that I can't disable though, so if you know how to do that, let me know:

No type errors found
Version: typescript 3.5.2

@bfred-it bfred-it merged commit be74449 into master Jul 7, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bfred-it bfred-it deleted the need-for-speed branch Jul 7, 2019

@jerone

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2019

Great work 馃じ鈥嶁檪锔

notlmn added a commit to notlmn/refined-github that referenced this pull request Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.