Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `linkify-user-location` feature #2544

Merged
merged 16 commits into from Nov 18, 2019
Merged

Conversation

@Tiramisu77
Copy link
Contributor

Tiramisu77 commented Nov 16, 2019

Closes #2116

linkifyloc

Test

Hover any user or organization profile or visit a user/organization profile, if location is present, it should be turned into a link to Google Maps.

On user profile pages, resize the browser window, the link should be preserved.


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

Tiramisu77 added 2 commits Nov 16, 2019
Tiramisu77 and others added 2 commits Nov 17, 2019
source/features/linkify-user-location.tsx Outdated Show resolved Hide resolved
source/features/linkify-user-location.tsx Outdated Show resolved Hide resolved
source/features/linkify-user-location.tsx Outdated Show resolved Hide resolved
source/features/linkify-user-location.tsx Outdated Show resolved Hide resolved
Tiramisu77 and others added 3 commits Nov 17, 2019
Co-Authored-By: Federico Brigante <github@bfred.it>
Co-Authored-By: Federico Brigante <github@bfred.it>
Copy link
Contributor Author

Tiramisu77 left a comment

currently fails to linkify profiles

source/features/linkify-user-location.tsx Outdated Show resolved Hide resolved
Tiramisu77 added 3 commits Nov 17, 2019
Tiramisu77 added 2 commits Nov 17, 2019
fregante added 4 commits Nov 18, 2019
@fregante

This comment has been minimized.

Copy link
Collaborator

fregante commented Nov 18, 2019

I regenerated the screenshot with some padding, correct underline and added the pointer cursor (I'm using this to make it links more clear, also for linkify-labels-on-dashboard). Then I also run ImageOptim on it

Screenshot

@fregante fregante merged commit ade7467 into sindresorhus:master Nov 18, 2019
3 checks passed
3 checks passed
AVA
Details
Lint
Details
Build
Details
@fregante

This comment has been minimized.

Copy link
Collaborator

fregante commented Nov 18, 2019

Thanks @Tiramisu77 for this feature! 🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.