New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download folder button #951

Merged
merged 4 commits into from Jan 17, 2018

Conversation

5 participants
@bfred-it
Collaborator

bfred-it commented Jan 5, 2018

Closes #815

It will look like this:

screenshot

The download page itself can be discussed and improved on the downloader tool's repo

@bfred-it bfred-it added the enhancement label Jan 5, 2018

@sindresorhus

This comment has been minimized.

Owner

sindresorhus commented Jan 17, 2018

Would be nice if we had a token field in our options, so we could just use it for this too, but that's for another PR.

@bfred-it

This comment has been minimized.

Collaborator

bfred-it commented Jan 17, 2018

Yeah once we get that in our settings I can update the tool to accept the token via URL parameters, if that doesn't sound too much of a risk.

@sindresorhus

This comment has been minimized.

Owner

sindresorhus commented Jan 17, 2018

Yes, no more risk than trusting us with the token in this extension. I would move the download-directory.github.io repo to your account, though, so it's immediately clear who they're trusting (a maintainer of this extension).

@sindresorhus

:shipit: when readme change is done.

@sindresorhus

This comment has been minimized.

Owner

sindresorhus commented Jan 17, 2018

This is really cool, by the way. I've often needed this.

@bfred-it

This comment has been minimized.

Collaborator

bfred-it commented Jan 17, 2018

I would move the download-directory.github.io repo to your account

I can't. That nice URL is only available to the download-directory org. It initially was bfred-it.github.io/github-download-dir, then github-download-dir.bfred.it, then that.

I can add my © Name in the tool itself but it's not like anyone knows me anyway.

@bfred-it

This comment has been minimized.

Collaborator

bfred-it commented Jan 17, 2018

Readme screenshot

screen shot 2018-01-17 at 20 11 59

@bfred-it bfred-it merged commit 2335a3f into master Jan 17, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@sindresorhus sindresorhus deleted the add-download-folder-button branch Jan 17, 2018

@sindresorhus

This comment has been minimized.

Owner

sindresorhus commented Jan 17, 2018

Ah ok, maybe add that that URL is trusted by Refined GitHub, so people are immediately aware how they ended up on a different URL.

@amarlearning

This comment has been minimized.

amarlearning commented Jan 17, 2018

@bfred-it @sindresorhus I think you people are looking for this.

@bfred-it

This comment has been minimized.

Collaborator

bfred-it commented Jan 17, 2018

We’re definitely not looking for python tools for a browser extension 😃

@druppi86

source/features/add-download-folder-button.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment